Conversation
Contributor
There was a problem hiding this comment.
Cambiar a ValueError, IOError es error de entrada y salida
Contributor
Author
There was a problem hiding this comment.
But if the api key is '12345' in the _call_api method urllib return 404 don't receive something.
Contributor
Author
There was a problem hiding this comment.
I just add another try in the _call_api method for this.
Contributor
There was a problem hiding this comment.
de hecho, este try no hace sentido ya que solo haces concatenación de cadenas, cual es la posibilidad qeu algo salga mal?
oscarmcm
changed the title
fitoria
added a commit
that referenced
this pull request
Aug 3, 2015
KTA-1 Fix Embedly error, Vimeo error, SimpleJson error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix this errors:
It's now in 1.0.0 version please create a new github release and upload this to PyPI.
Note: Please add PyPI Badge to the readme.md file, read more here.DONE 😄